Delta-Icons / android

🤖 Icon Pack for Android
https://delta-icons.github.io
Other
577 stars 115 forks source link

Added 7 Icons (including 3 updates) + 1 ComponentInfo #922

Closed eeelbrens closed 2 months ago

eeelbrens commented 2 months ago

Added:

Updated:

also, an important question: I haven't contributed new icons in 2 months and saw your new documentation change and reshuffling. For the updates I still use my very own method of overwriting the icons then adding the alts to resources/utilities/icons (or contribs/icons for the sake of the docs change), which has the advantage of zero commits in drawable.xml files. Is this still a valid solution, which I see absolutely no issues with, given how the app and its files are structured? Can this method be added to the documentation as a quick (alt of course) method for updating apps with "less contributor-side errors"?

flameshikari commented 2 months ago

Hm, actually a nice idea, but there are some side effects: old icons (alts) will be in the 'New' category section but new ones won't.

I got an idea based on your suggestion: I can add additional parameters for entries in icons.yml, for example something like this:

max_stream:
  old_to_alt: true
  category: M
  compinfos:
    - com.wbd.stream/com.wbd.fuse.appcore.FuseActivity

It will be useful for manipulating specific icons (like Google apps) and cases like yours. Sure I will implement it, however I need some time to think about side effects, then some time to code and document it. For now, do it in the old way, please.

And yeah, it will be backwards compatible. I mean, you'll still can do this:

max_stream:
  - com.wbd.stream/com.wbd.fuse.appcore.FuseActivity

...if you don't need to manipulate with the icon like in the first example.

eeelbrens commented 2 months ago

@flameshikari All done! Looking forward to your implementation!

flameshikari commented 2 months ago

Will do my best!