Delta2Force / MCVmComputers

Order computer parts from a satellite orbiting around your minecraft world and build actual working computers with them!
Other
501 stars 58 forks source link

VMware #258

Closed goosetalk closed 1 year ago

goosetalk commented 2 years ago

Can you publish VMWare Edition?I don't like VirtualBox,it's not good for me

Maxey1950 commented 2 years ago

Yea I really want one for vmware workstaion pro @everyone @Owener

Meister1593 commented 2 years ago

there was an attempt on doing qemu, but it was stalled Overall project is a bit stalled and requires major refactor

goosetalk commented 2 years ago

曾尝试做 qemu,但停滞不前 整体项目有点停滞,需要重大重构

I think the compatibility is not good

goosetalk commented 2 years ago

Also, what is the working principle of the module? Can you send a docx that works

goosetalk commented 2 years ago

Can I participate in development

Meister1593 commented 2 years ago

Can I participate in development

You can send pull requests and they probably will be reviewed, especially considering that commits were made very recently. As for documentatiom - there is none for the code as far as I am aware. This mod needs very heavy refactor in area of managing inputs on screen, passing byteimage to other players and so on. I personally wanted to make some progress, but was busy at my university. Next week I might try an attempt on starting refactor/rewrite. I will let you know when that happens. There is a hope and some ideas on how this can be improved.

Delta2Force commented 2 years ago

Can I participate in development

You can send pull requests and they probably will be reviewed, especially considering that commits were made very recently. As for documentatiom - there is none for the code as far as I am aware. This mod needs very heavy refactor in area of managing inputs on screen, passing byteimage to other players and so on. I personally wanted to make some progress, but was busy at my university. Next week I might try an attempt on starting refactor/rewrite. I will let you know when that happens. There is a hope and some ideas on how this can be improved.

I myself have a very large break coming up soon and thought about just creating a new repo and starting from scratch, making it more modular and paying more attention to actually writing good code. Back when I wrote this it was basically just for a cool gif so I wrote awful code. Also I consistently committed code that wouldn't compile to master even though I wanted to structure it as an open source project. If you want, we can get in touch and work on it together, maybe even make something outside of the gimmick that it currently is (tech mod?)

Meister1593 commented 2 years ago

Can I participate in development

You can send pull requests and they probably will be reviewed, especially considering that commits were made very recently. As for documentatiom - there is none for the code as far as I am aware. This mod needs very heavy refactor in area of managing inputs on screen, passing byteimage to other players and so on. I personally wanted to make some progress, but was busy at my university. Next week I might try an attempt on starting refactor/rewrite. I will let you know when that happens. There is a hope and some ideas on how this can be improved.

I myself have a very large break coming up soon and thought about just creating a new repo and starting from scratch, making it more modular and paying more attention to actually writing good code. Back when I wrote this it was basically just for a cool gif so I wrote awful code. Also I consistently committed code that wouldn't compile to master even though I wanted to structure it as an open source project. If you want, we can get in touch and work on it together, maybe even make something outside of the gimmick that it currently is (tech mod?)

i'm all for it, sure

KingTino104 commented 2 years ago

Agree, you should start from scratch, this hasn't received updates, and it's better to start from scratch because nobody will use this even if you update it.

goosetalk commented 1 year ago

ok

y2k04 commented 1 year ago

@goosetalk I am updating it to 1.19.2 right now. The code does require some work (replacing obsolete and deprecated methods and classes), but so far it is going well with going through each class one by one to fix the errors. I also made it grab the latest VirtualBox SDK and moving vboxjws.jar to the lib folder. So with that it now supports VirtualBox 7.0.4.

poopdog000 commented 1 year ago

@goosetalk I am updating it to 1.19.2 right now. The code does require some work (replacing obsolete and deprecated methods and classes), but so far it is going well with going through each class one by one to fix the errors. I also made it grab the latest VirtualBox SDK and moving vboxjws.jar to the lib folder. So with that it now supports VirtualBox 7.0.4.

make it work with VMware

y2k04 commented 1 year ago

That is being researched currently, but there is not much documentation that is useful. We are better off investing time in QEMU development instead of VMware unfortunately.

y2k04 commented 1 year ago

Closing issue due to it not being able to be implemented. (I'm sad too)

goosetalk commented 1 year ago

Sorry, I've been a bit busy lately and can't reply

y2k04 commented 1 year ago

Don't worry :)

y2k04 commented 1 year ago

Duplicate of #80