DeltaBalances / DeltaBalances.github.io

The Ethereum decentralized exchange assistant. Check token balances, transaction details & trade history.
https://deltabalances.github.io/
GNU General Public License v3.0
169 stars 67 forks source link

1 minor bug and 1 minor feature request for deltabalances #60

Closed rory4ever closed 5 years ago

rory4ever commented 5 years ago

Hi,

I would like to report 1 minor bug concerning the sorting of the tokens (wallet overview) When the wallet opens, I can click on a token and then open for example the direct link to etherdelta or forkdelta or other supported exchanges. This works great. However, when I, for example, want to sort using "est eth" (or any other for that matter) the following happens:


Is there a way to address the problem where one has too many (worthless) tokens, like for example the token "CTC" or some xxx_OLD tokens and in the wallet overview the tokens are shown in full (all decimals shown) This way the layout becomes almost unreadable and one needs to scroll a lot from left to right) I attached a screenshot.

screenshot from 2018-10-19 20-27-47

On the exchanges these tokens are abbreviated to for example 15e+37 and I think it is a good idea to use the same standard for the values in the wallet overview. Many thanks in advance!

DeltaBalances commented 5 years ago

Thanks for the detailed report.

The high token amounts are something I probably missed because the wallets that I tested never realy had that high amounts. Will definitely fix that.

The token popup not always showing up is a bug I'm aware of. It shows up now and then but I never really noticed it is that easy to reproduce. Might be easier to change the entire popup behavior but I'll see how that works out.

(I also didn't forget about the multi-address history thing, it's on the list)

DeltaBalances commented 5 years ago

Can you check if both of these don't happen anymore?

rory4ever commented 5 years ago

Hi,

Checked the large numbers, in both wallet overview and trade history -> solved! Checked the token popup issue, checked with different sorting methods (est eth, total, etc...) -> solved!

Many thanks for the quick resolve :)