search

DeltaE / Canada-U.S.-ElecTrade

The Role of U.S.-Canada Electricity Trade in North American Decarbonization Pathways
2 stars 0 forks source link

Updated Snakemake Formatting #120

Closed trevorb1 closed 2 years ago

trevorb1 commented 2 years ago

Updated the snakefile to match the documentation suggested standards (ie. it now passes snakemake --lint), and removed any non-used import statements from the modules

Included in the update:

trevorb1 commented 2 years ago

There is a small rounding difference happening in the residualCapacity.py file happening now. About 50 techs have different values at the 3 decimal place (see sample below). I updated a bunch of my packages so I am thinking its just something to due with that? 

ResidualCapacity.csv
The two files are different.

Deleted Elements:
NAmerica PWRCCGUSAFL01 2019 36.284
NAmerica PWRCTGUSATX01 2035 14.34
NAmerica PWRCOAUSACA01 2031 0.006
NAmerica PWRCOAUSACA01 2049 0.002
NAmerica PWRHYDUSASW01 2026 2.79
NAmerica PWRHYDUSAFL01 2019 0.044
...

Added Elements:
NAmerica PWRCCGUSAFL01 2019 36.285
NAmerica PWRCTGUSATX01 2035 14.341
NAmerica PWRCOAUSACA01 2031 0.005
NAmerica PWRCOAUSACA01 2049 0.003
NAmerica PWRHYDUSASW01 2026 2.791
NAmerica PWRHYDUSAFL01 2019 0.043
...
Kiel-SFU commented 2 years ago

According to https://snakemake.readthedocs.io/en/stable/snakefiles/deployment.html, Snakemake recommends a particular file organization structure (for example, the snakefile and envs are in a folder called 'workflow'). Do you think we should structure the codebase more closely to this, or even in the exact suggested way?

trevorb1 commented 2 years ago

Good point, and its part of the update coming !