In pr #74 we switched to creating all model data at once, instead of creating canada data then usa data then merging the data sets together. In this process we combined some scripts together, and there is still some weird artifacts left from this process. For example. in RETags.py, we create the Canada RETags in main(), then call a function to create the usa RETags, then combine the two dataframes together in main().
It will probably make more sense to just have a general function (similar to whats there now) that we call twice in main to create country coded RETags, then combine the two dataframes together.
This is just one example, but we should do a thorough review of all the code to check for weird things like this
In pr #74 we switched to creating all model data at once, instead of creating canada data then usa data then merging the data sets together. In this process we combined some scripts together, and there is still some weird artifacts left from this process. For example. in
RETags.py, we create the Canada RETags inmain(), then call a function to create the usa RETags, then combine the two dataframes together inmain().https://github.com/DeltaE/Canada-U.S.-ElecTrade/blob/7ba1696f95cbf5c31f726368d2ec69e019c00371/scripts/RETags.py
It will probably make more sense to just have a general function (similar to whats there now) that we call twice in main to create country coded RETags, then combine the two dataframes together.
This is just one example, but we should do a thorough review of all the code to check for weird things like this