DeltaEscher / editra

Automatically exported from code.google.com/p/editra
Other
0 stars 0 forks source link

No "uninstall" button for a plugin #489

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
We have a plugin named "Jaluino_debugger", for which there's no "Uninstall" 
option in plugin listing. I tracked this down and found plugin system looks 
for "jaluino-debugger" instead of "jaluino_debugger".

Is this related to setuptools ?

Here's some configuration data:

setup.py:
...
if setup != None:
    setup(
            name='Jaluino_debugger',
    ...
     entry_points='''
     [Editra.plugins]
     Jaluino_debugger = jaluino_debugger:Jaluino_debugger
...

When compiling this to produce an egg, PKG-INFO contains this line:

Name: Jaluino-debugger

That's why I think it might be related to setuptools.

That said, this leads to some special case in Editra code, in plugdlg.py:

"""
        ipath = self.GetInstallPath()
        if ipath:
            if not os.access(ipath, os.R_OK|os.W_OK):
                self._uninstall.Show(False)
        else:
            self._uninstall.Show(False) # Should not happen
"""

well it has happened :)
I don't know what's the proper may to deal with this, maybe at least 
reporting this to user ?

Cheers,
Seb

Original issue reported on code.google.com by sebastie...@gmail.com on 28 Feb 2010 at 9:30

GoogleCodeExporter commented 8 years ago
I added a log message.

I suggest you rename you folders using a more standard naming convention
'JaluinoDebugger".

What is the actual file name of your plugin look like?

Original comment by CodyPrec...@gmail.com on 28 Feb 2010 at 4:52

GoogleCodeExporter commented 8 years ago
We indeed renamed it "JaluinoDebugger". File name was "Jaluino_debugger", 
everything 
was displayed using this name, except for setuptools.

Thanks
Seb 

Original comment by sebastie...@gmail.com on 28 Feb 2010 at 5:54

GoogleCodeExporter commented 8 years ago
Hi,

What was the actual file name of you plugin though ***.egg?

What does "except for setuptools" mean in the sentence above?

Thanks,

Cody

Original comment by CodyPrec...@gmail.com on 28 Feb 2010 at 5:57

GoogleCodeExporter commented 8 years ago
Egg was name "Jaluino_debugger-0.1.egg". By "except for setuptools", I mean 
that when 
querying egg's name using setuptools (IIRC this is what's done while listing 
plugins), 
the answer was "Jaluino-debugger".

Seb 

Original comment by sebastie...@gmail.com on 28 Feb 2010 at 6:02

GoogleCodeExporter commented 8 years ago
Ok,

I am guessing that setuptools must convert _ to - in names for some reason. 
There
isn't much I can do about this so will close this issue as wont fix.

Original comment by CodyPrec...@gmail.com on 28 Feb 2010 at 7:48