search

DeltaRCM / pyDeltaRCM

Delta model with a reduced-complexity approach
https://deltarcm.org/pyDeltaRCM/
MIT License
18 stars 11 forks source link

Bugfix: hooks for parallel jobs, check calls in test #207

Closed elbeejay closed 3 years ago

elbeejay commented 3 years ago

The requirement that we "defer output" for the parallel jobs splits some of the initial output file creation to the preprocessor's ParallelJob. As hooks were added/changed we didn't include these hooks in the ParallelJob code.

This PR provides a fix by adding the hooks, and expanding the corresponding unit test. We could consider lumping these functions and hooks into a single call, but I am not sure it is worth doing for such a small group of functions that are currently well defined.

codecov[bot] commented 3 years ago

Codecov Report

Merging #207 (f0f19fb) into develop (85c9f59) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
+ Coverage    78.95%   78.97%   +0.02%     
===========================================
  Files           12       12              
  Lines         2542     2545       +3     
===========================================
+ Hits          2007     2010       +3     
  Misses         535      535
Impacted Files Coverage Δ
pyDeltaRCM/preprocessor.py 83.98% <100.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85c9f59...f0f19fb. Read the comment docs.