search

DeltaRCM / pyDeltaRCM

Delta model with a reduced-complexity approach
https://deltarcm.org/pyDeltaRCM/
MIT License
18 stars 11 forks source link

Salter JOSS review reply - part2 #221

Closed amoodie closed 3 years ago

amoodie commented 3 years ago

Address comments from salterg review (#217).

codecov[bot] commented 3 years ago

Codecov Report

Merging #221 (f6610f4) into develop (dc9dff6) will decrease coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #221      +/-   ##
===========================================
- Coverage    78.69%   78.59%   -0.11%     
===========================================
  Files           12       12              
  Lines         2558     2560       +2     
===========================================
- Hits          2013     2012       -1     
- Misses         545      548       +3
Impacted Files Coverage Δ
pyDeltaRCM/init_tools.py 97.02% <ø> (ø)
pyDeltaRCM/shared_tools.py 75.49% <100.00%> (ø)
pyDeltaRCM/model.py 89.46% <0.00%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc9dff6...f6610f4. Read the comment docs.