search

DeltaRCM / pyDeltaRCM

Delta model with a reduced-complexity approach
https://deltarcm.org/pyDeltaRCM/
MIT License
18 stars 10 forks source link

Fix save_grids() #238

Closed elbeejay closed 2 years ago

elbeejay commented 2 years ago

Implements fix discussed in #236. Change logs the error message in the log-file and then raises it. Adds test to make sure error handling works as intended.

edit: so this closes #236

codecov[bot] commented 2 years ago

Codecov Report

Merging #238 (9986499) into develop (6bc253b) will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #238      +/-   ##
===========================================
+ Coverage    78.69%   78.85%   +0.15%     
===========================================
  Files           12       12              
  Lines         2577     2577              
===========================================
+ Hits          2028     2032       +4     
+ Misses         549      545       -4
Impacted Files Coverage Δ
pyDeltaRCM/_version.py 100.00% <100.00%> (ø)
pyDeltaRCM/iteration_tools.py 97.98% <100.00%> (+2.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bc253b...9986499. Read the comment docs.