search

DeltaRCM / pyDeltaRCM

Delta model with a reduced-complexity approach
https://deltarcm.org/pyDeltaRCM/
MIT License
18 stars 11 forks source link

add parallel to words not to write out to file from the preprocessor. #259

Closed amoodie closed 2 years ago

amoodie commented 2 years ago

minor warning-related bugs due to #252

codecov[bot] commented 2 years ago

Codecov Report

Merging #259 (25cf980) into develop (86251f9) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #259      +/-   ##
===========================================
- Coverage    78.86%   78.86%   -0.01%     
===========================================
  Files           12       12              
  Lines         2617     2616       -1     
===========================================
- Hits          2064     2063       -1     
  Misses         553      553
Impacted Files Coverage Δ
pyDeltaRCM/init_tools.py 97.18% <100.00%> (+0.01%) :arrow_up:
pyDeltaRCM/preprocessor.py 83.98% <100.00%> (-0.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86251f9...25cf980. Read the comment docs.

elbeejay commented 2 years ago

We were still emitting warnings saying some keywords were not being used, even when they were. This was happening for "special" parameters that were handled by the preprocessor and not the model. These include timesteps, time, time_years, config, and dryrun, the latter two of which are generated when multiple jobs are spun out by the ensemble, set, or matrix use-cases.

Changes simply drop these "special" parameters from the parameter dictionary in the import_files() method before the checks for the unused and preprocessor keywords happens. Some tests are added to make sure that no warnings are emitted when these keywords are present in the YAML file.