search

DeltaRCM / pyDeltaRCM

Delta model with a reduced-complexity approach
https://deltarcm.org/pyDeltaRCM/
MIT License
18 stars 11 forks source link

Init eta checkpoint #283

Closed amoodie closed 6 months ago

amoodie commented 6 months ago

Rework the integration of these new fields into the checkpointing.

My prev PR (#281) was not thoroughly considered, and therefore was a breaking change, when I didn't mean for it to be. This PR adds handling and a warning when these fields are not found in a checkpoint file, but allows the loading to proceed.

Also fixes the broken documentation, because that checkpoint file was not working.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.92%. Comparing base (27d0f45) to head (23bc8cf). Report is 3 commits behind head on develop.

Files Patch % Lines
pyDeltaRCM/init_tools.py 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #283 +/- ## =========================================== + Coverage 78.88% 78.92% +0.04% =========================================== Files 12 12 Lines 2619 2634 +15 =========================================== + Hits 2066 2079 +13 - Misses 553 555 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.