Medical scrubs expansion

[VMSolidus]

About the PR

This is adding six new scrub colors to the game for Medical mains to express themselves. One of which requires an Emag to access. They can be found in Medical Scrub cates, order some from Cargo! Or maybe station medbays might start getting stocked with them!

Media

• [X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog :cl: VMSolidus

• remove: Scrubs can no longer be obtained from the MediDrobe
• add: NT may have forgotten to check their MediDrobes for contraband
• add: Eight different colors of scrubs and surgical caps can now be found in medical scrub crates!
• add: Scrubs can now spawn in one of 8 exciting new colors. Please report sightings of a mysterious 9th color to management.(this needs to be mapped in)

[github-actions[bot]]

RSI Diff Bot; head commit 807250efc468a89ee29398e9247fcc832109de8b merging into d75b282f93b2f22d450fa523c9d76fcd560a1d39 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_black.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_cyan.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_cybersun.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_pink.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_rainbow.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Head/Hats/surgcap_white.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HELMET | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/black.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/cyan.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/cybersun.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/pink.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/rainbow.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Resources/Textures/DeltaV/Clothing/Uniforms/Scrubs/white.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-INNERCLOTHING | ![]() |  | Added | icon | ![]() |  | Added | inhand-left | ![]() |  | Added | inhand-right | ![]() |  | Added

Edit: diff updated after 807250efc468a89ee29398e9247fcc832109de8b

[Colin-Tel]

I think it would be better to put the new scrubs into the medical scrubs crate (but keep the emag inventory). Doing that would reduce the bloat in the medidrobe, while still allowing people to get the scrubs if they want. It also makes them more uncommon, making them cool outfits to either be mapped or just bring additional value to the medical scrubs crate.

[Carolyn3114]

I think it would be better to put the new scrubs into the medical scrubs crate (but keep the emag inventory). Doing that would reduce the bloat in the medidrobe, while still allowing people to get the scrubs if they want. It also makes them more uncommon, making them cool outfits to either be mapped or just bring additional value to the medical scrubs crate.

so true

[VMSolidus]

I have gone ahead and made the requested changes. Scrubs(except for the Cybersun/Syndicate scrubs, which are new cosmetic items found in MediDrobe's emag inventory) can instead be obtained from the Medical Scrub Crate. Since there's now 8 different kinds of scrubs in the crate, it has been slightly nerfed to only contain 1 of each scrub. I do still feel this is fair for its pricing, since it merely contains cosmetic items. If people want more of their favorite scrub color, they can always order the crate again from cargo.

[VMSolidus]

Alright and now I have one more new addition to this PR. I've created a custom spawner for the mappers, so that these scrubs can be added as random spawns to station medbays.

[VMSolidus]

Also, I have an open question for the maintainers. Should the Cybersun Scrubs be emaggedInventory or contrabandInventory? The former makes them explicitly a traitor item, while the later requires that one only needs to hack the vendor to get them, such as with wire cutters or a multitool.

[VMSolidus]

Hold off on pulling this for a bit, Im still working on some things. The last thing Im adding is proper traitor uplink support for Cybersun drip, and awaiting input on some balancing stuff

[VMSolidus]

Okay, I'm going to request a review/pull on this now. I've decided that adding a new traitor uplink item to this PR is kind of outside scope. Especially since on my private branch, I'm working on an entire new system for traitor clothing bundles, which is MAJORLY outside scope for this particular branch. Therefore I will declare that this PR is complete.

[DEATHB4DEFEAT]

From my POV, this looks good! If this were on the rebase, I'd approve it (as long as you made sure to comment on the upstream files you altered).

You can still approve PRs, you just won't affect mergeability.

[VMSolidus]

Tests failed for entirely unrelated reasons. I'd like to request a review and merge.

[Colin-Tel]

From my POV, this looks good! If this were on the rebase, I'd approve it (as long as you made sure to comment on the upstream files you altered).

You can still approve PRs, you just won't affect mergeability.

:trollface:

Anyways I stand by the fact you should comment any changes on upstream files where possible.

[VMSolidus]

From my POV, this looks good! If this were on the rebase, I'd approve it (as long as you made sure to comment on the upstream files you altered).

You can still approve PRs, you just won't affect mergeability.

:trollface:

Anyways I stand by the fact you should comment any changes on upstream files where possible.

It actually won't matter because we aren't merging this with rebase, and all these changes are going to be abandoned anyway whenever rebase is done. I have an equivalent PR in the works on rebase, but it's waiting on me getting off my ass and making the changes Wizden wants to their upstream. Guh that's so annoying.