search

DeltaV-Station / Delta-v

A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
https://delta-v.org
GNU Affero General Public License v3.0
47 stars 213 forks source link

Ninja phase cloak broke (oopsie!) #1326

Open adeinitas opened 1 month ago

adeinitas commented 1 month ago

Description

Ninja's phase cloak broke a while ago, have no clue why.

Reproduction

Be a Ninja. Try to turn invisible with your high-tech phase cloak provided by the spider clan. Fail. Cry.

Additional context

This has been a lingering issue for a bit, surprised no one made a github issue about it. All signs seem to be pointing towards it not being an upstream issue with StealthComponent - I'd wager this has to do with its interaction with Invisibility somehow, as a psionic power. It seems to work on cobras, on boxes, on everything else that just goes invisible, but not people.

deltanedas commented 1 month ago

works in ninja/toggle refactor upstream so can probably just wait on that

adeinitas commented 2 weeks ago

There was an upstream merge since you said that and I'm pretty sure it's linked to the aging psionics shitcode and that, in fact, it's an us issue

deltanedas commented 2 weeks ago

more than likely related to psionic invis being broken