Taking the Senior ID card for jobs that support it will change your job title and icon to match that of the senior role.
My advice to heads of staff: Treat your seniors like they have 60 hours of playtime. Delegate them to teach recruits properly, do things that are hard and condemn them harshly for incompetence.
This solution reverts https://github.com/DeltaV-Station/Delta-v/pull/1218 and moves most of the job name changing logic to take place in C.S/.../GameTicker.Spawning to catch when the player spawns both at round-start and the middle of the round. Various overrides in a few scripts check for VirtualJobName/Icon in a JobComponent.
No longer uses job prototypes like in Attempt 2.
About the PR
Taking the Senior ID card for jobs that support it will change your job title and icon to match that of the senior role.
My advice to heads of staff: Treat your seniors like they have 60 hours of playtime. Delegate them to teach recruits properly, do things that are hard and condemn them harshly for incompetence.
Why / Balance
Fixes https://github.com/DeltaV-Station/Delta-v/issues/1263
Technical details
This solution reverts https://github.com/DeltaV-Station/Delta-v/pull/1218 and moves most of the job name changing logic to take place in
C.S/.../GameTicker.Spawningto catch when the player spawns both at round-start and the middle of the round. Various overrides in a few scripts check for VirtualJobName/Icon in a JobComponent. No longer uses job prototypes like in Attempt 2.Media
https://youtu.be/_YaD1ESBiwA
Breaking changes
Changelog
:cl: