DeltaV-Station / Delta-v

A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
https://delta-v.org
GNU Affero General Public License v3.0
46 stars 203 forks source link

Split Emag in half #1426

Open WarMechanic opened 1 week ago

WarMechanic commented 1 week ago

About the PR

Splits the functionality of Emag into two different items:

Why / Balance

Emag is a very big item which makes it hard to balance. On one hand, its a gimmick enabler by creating special interactions with station machines. On the other hand, it is very efficient at breaking and entering anywhere with a door. Most players will want to buy the Emag for one function or the other.

By splitting Emag into these two functions, the collective cost of Emag will stay at 10 but Syndicate players will have more agency over what they want to do in a round with budget cuts. The cost of either item can be interpolated based on which one is more powerful.

Technical details

Adds whitelist and blacklist variables to the Emag component.

Media

https://youtu.be/c0NuEvLdc_U image image

Breaking changes

No

Changelog

:cl:

deltanedas commented 1 week ago

This PR is currently awaiting a sprite for the AAO.

doesnt tg have it

WarMechanic commented 1 week ago

This PR is currently awaiting a sprite for the AAO.

doesnt tg have it

it does but it also has different cryptographic sequencer and id card sprites which would look out of place here. i guess i could use it temporarily for testing but i dont know how attributions work so i dont want to bother lol. i got someone on discord to work on a new sprite so we good.

github-actions[bot] commented 1 week ago

RSI Diff Bot; head commit f4d304d38f1a71b105f1b334cbf77d071e3f683e merging into 4a2a11ee286e1e2c9e96e9937e5a886e06a9464a This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Tools/doorjack.rsi

| State | Old | New | Status | --- | --- | --- | --- | | icon | ![]() | ![](https://raw.githubusercontent.com/WarMechanic/Delta-v/f4d304d38f1a71b105f1b334cbf77d071e3f683e/Resources/Textures/DeltaV/Objects/Tools/doorjack.rsi/icon.png) | Added | inhand-left | ![]() | ![](https://raw.githubusercontent.com/WarMechanic/Delta-v/f4d304d38f1a71b105f1b334cbf77d071e3f683e/Resources/Textures/DeltaV/Objects/Tools/doorjack.rsi/inhand-left.png) | Added | inhand-right | ![]() | ![](https://raw.githubusercontent.com/WarMechanic/Delta-v/f4d304d38f1a71b105f1b334cbf77d071e3f683e/Resources/Textures/DeltaV/Objects/Tools/doorjack.rsi/inhand-right.png) | Added

Edit: diff updated after f4d304d38f1a71b105f1b334cbf77d071e3f683e

Lyndomen commented 1 week ago

I think the admin team is really excited about this, and look forward to it if it is implemented.

WarMechanic commented 4 days ago

all requested changes are resolved, all checks have passed and it still works in game so it looks good to me