search

DeltaV-Station / Delta-v

A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
https://delta-v.org
GNU Affero General Public License v3.0
64 stars 276 forks source link

Sound effects may play for players in lobby during post-round #1767

Open pissdemon opened 1 month ago

pissdemon commented 1 month ago

Description

You can sometimes hear sound effects or snippets of sound effects, all of which are non-global (e.g. satchel opening or closing), when you are in the lobby of a post-round game. You should not be able to hear those since you are in the lobby and they are not global sounds. (Certain global sounds playing in the lobby like weather sounds is also an issue, but a separate one from this.)

Reproduction

  1. Be connected and in the lobby, do not join
  2. Wait until a round ends
  3. You may hear some sound effects (but notably, not ALL of them, and they can sound "cut off")

Additional context Probably an upstream issue, but filing here since I haven't gotten around to check. Maybe related to game state, since I think post-round is a separate game state, maybe there is an issue in audio code with how lobby players are handled post-round vs in-round.

ghost commented 1 month ago

As far as I know this is an upstream issue because this also happens everywhere I go - Goob, Frontier, what have you. If someone's running an event with weather it escapes and goes to the lobby (seperate issue.) You hear the flare sound at roundend. Probably involves audio code in some sense, doubt it's local to here.