search

DeltaV-Station / Delta-v

A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
https://delta-v.org
GNU Affero General Public License v3.0
70 stars 301 forks source link

Hardsuits now block defibulators #2251

Open beck-thompson opened 1 day ago

beck-thompson commented 1 day ago

About the PR

Title! Defibs now are blocked by hardsuits.

Why / Balance

I asked in the discord, majority of people seemed to want it. It makes sense and will make medical have to think about defibbing fully armored security.

Also, requires: https://github.com/space-wizards/space-station-14/pull/31147 To be merged before it works! (I'll also add comments and localization stuff when that happens as I want it fully merged before doing testing and stuff)

Media

todo

Requirements

Changelog

:cl:

BlitzTheSquishy commented 1 day ago

Gonna need to make sure that softsuits, (Prisoner, Emergancy, Basic, Clown, Mime, Syndicate) dont, and yes clown and mime are softsuits, not hardsuits (despite their name)

Lyndomen commented 1 day ago

💯💯

beck-thompson commented 1 day ago

Gonna need to make sure that softsuits, (Prisoner, Emergancy, Basic, Clown, Mime, Syndicate) dont, and yes clown and mime are softsuits, not hardsuits (despite their name)

Sounds good, when the required PR actually gets merged I'll do more testing to make sure it works on the right things and stuff

BlitzTheSquishy commented 1 day ago

Gonna need to make sure that softsuits, (Prisoner, Emergancy, Basic, Clown, Mime, Syndicate) dont, and yes clown and mime are softsuits, not hardsuits (despite their name)

Sounds good, when the required PR actually gets merged I'll do more testing to make sure it works on the right things and stuff

Also currently where that's placed- it looks like EVERY outer slot item will block defib (would include vox tank harnesses i believe)

also you should be testing it BEFORE it gets merged

beck-thompson commented 1 day ago

also you should be testing it BEFORE it gets merged

How? I mean I guess I could like chery pick the required PR ahead of time but I personally don't think that's worth the effort. I mostly made this early so people could give their opinions. If people don't want it, then I wont bother putting the work in finding all the weird hardsuit edge cases

BlitzTheSquishy commented 1 day ago

also you should be testing it BEFORE it gets merged

How? I mean I guess I could like chery pick the required PR ahead of time but I personally don't think that's worth the effort. I mostly made this early so people could give their opinions. If people don't want it, then I wont bother putting the work in finding all the weird hardsuit edge cases

pull the merge to your dev or make a dev enviro on wizden (which its already merged) and test there, cause we use similar stuff so