DeltaV-Station / Delta-v

A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
https://delta-v.org
GNU Affero General Public License v3.0
70 stars 304 forks source link

Make brass textures look nicer #2258

Open pontaoski opened 4 days ago

pontaoski commented 4 days ago

About the PR

The brass sheets now have new sprites that look shinier and more brass-coloured.

Why / Balance

The previous brass sheets have a dull and non-shiny texture, as well as a confusing indentation. They immediately stuck out to me as looking unsatisfactory.

Media

grafik

Requirements

Changelog

:cl:

github-actions[bot] commented 4 days ago

RSI Diff Bot; head commit cba5e31d5cc0c24f604d3f5bbbe15416b742947e merging into c7b894f93bcc38fb74021717f716d7a5ac6a12f4 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Materials/Sheets/metal.rsi

| State | Old | New | Status | --- | --- | --- | --- | | brass-inhand-left | ![](https://raw.githubusercontent.com/DeltaV-Station/Delta-v/c7b894f93bcc38fb74021717f716d7a5ac6a12f4/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass-inhand-left.png) | ![](https://raw.githubusercontent.com/pontaoski/Delta-v/cba5e31d5cc0c24f604d3f5bbbe15416b742947e/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass-inhand-left.png) | Modified | brass-inhand-right | ![](https://raw.githubusercontent.com/DeltaV-Station/Delta-v/c7b894f93bcc38fb74021717f716d7a5ac6a12f4/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass-inhand-right.png) | ![](https://raw.githubusercontent.com/pontaoski/Delta-v/cba5e31d5cc0c24f604d3f5bbbe15416b742947e/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass-inhand-right.png) | Modified | brass | ![](https://raw.githubusercontent.com/DeltaV-Station/Delta-v/c7b894f93bcc38fb74021717f716d7a5ac6a12f4/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass.png) | ![](https://raw.githubusercontent.com/pontaoski/Delta-v/cba5e31d5cc0c24f604d3f5bbbe15416b742947e/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass.png) | Modified | brass_2 | ![](https://raw.githubusercontent.com/DeltaV-Station/Delta-v/c7b894f93bcc38fb74021717f716d7a5ac6a12f4/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass_2.png) | ![](https://raw.githubusercontent.com/pontaoski/Delta-v/cba5e31d5cc0c24f604d3f5bbbe15416b742947e/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass_2.png) | Modified | brass_3 | ![](https://raw.githubusercontent.com/DeltaV-Station/Delta-v/c7b894f93bcc38fb74021717f716d7a5ac6a12f4/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass_3.png) | ![](https://raw.githubusercontent.com/pontaoski/Delta-v/cba5e31d5cc0c24f604d3f5bbbe15416b742947e/Resources/Textures/Objects/Materials/Sheets/metal.rsi/brass_3.png) | Modified

Edit: diff updated after cba5e31d5cc0c24f604d3f5bbbe15416b742947e

Unkn0wnGh0st333 commented 3 days ago

I find it too bright; a feature of the old one was the unusual design made it stand out compared to other resources. However, I get the previous version was too dark, but this new one is overly bright as well.

pontaoski commented 3 days ago

grafik

remember that ingame lighting is usually pretty subdued - once subjected to it & in relation to other things it isn't as nearly as bright as it is in isolation

Unkn0wnGh0st333 commented 3 days ago

grafik

remember that ingame lighting is usually pretty subdued - once subjected to it & in relation to other things it isn't as nearly as bright as it is in isolation

I am aware of the in-game lighting but you actually did perfect with this image cause to me it unironically looks like glass.

pontaoski commented 2 days ago

grafik

the shininess and overall colour palette has been subdued

deltanedas commented 2 days ago

looks much nicer now