The idea for alignment of havengetallen and tidalindicators in https://github.com/Deltares-research/kenmerkendewaarden/issues/79 did not work perfectly. Therefore, the coupling to moonculminations remains important. In order to also be able to derive these values for other regions than the Dutch coast, the offset between moonculminations and high waters should be flexible.
Todo:
[x] make the current hard-coded value of 4 flexible with a moonculm_offset argument for kw.calc_havengetallen()
[x] give a warning if df_havengetallen["HW_values_median"].idxmax() != 0. This is the case for DELFZL, if we use the default num_extremes_offset=4 we get idxmax=11. >> this does not make sense since we also get this warning for HOEKVHLD.
The idea for alignment of havengetallen and tidalindicators in https://github.com/Deltares-research/kenmerkendewaarden/issues/79 did not work perfectly. Therefore, the coupling to moonculminations remains important. In order to also be able to derive these values for other regions than the Dutch coast, the offset between moonculminations and high waters should be flexible.
Todo:
moonculm_offsetargument forkw.calc_havengetallen()df_havengetallen["HW_values_median"].idxmax() != 0. This is the case for DELFZL, if we use the defaultnum_extremes_offset=4we getidxmax=11. >> this does not make sense since we also get this warning for HOEKVHLD.