[ ] PH: KWK en KW lopen uiteen met oude gegevens. RvdW gaf aan dat dit vooral anders is voor de laagfrequente getallen en die komen uit HYDRA-NL (uitgevoerd door HKV, op aansluiten?). Wel goed om voor HvH te kijken of we overeenkomst kunnen vinden, hoewel dat ook mogelijk uit twee verschillende databases komt wbt laagfrequente overschrijdingsfreqs.
[ ] resulting freqs seem to be shifted w.r.t. getijtafelboekje (mail PH 9-3-2022)
[ ] is "gecombineerd" based on BOI method? It should be. Which is last measurement freq and first hydra freq?
[ ] align method with BOI
[ ] avoid need for p-drive link for HYDRA-NL data, link to online database possible?
[ ] move from HYDRA-NL to HYDRA-RING or different source? (also possible to get e.g. 2011 values? Depends on "zichtjaar" 2011(?)/2023/2035/etc and SLR choices), WBI2017 has zichtjaar 2023
[ ] databases WBI2017 (zichtjaar 2023) are available online via STACK
[ ] HYDRA-RING is executable, so this can be called by using database as input, but requires sqlite database (which requires quite some work to set up properly). In 2024 there will be worked on a HYDRA-RING Python wrapper, which makes this easier. For now, manual computation in Riskeer might be easier >> discuss with KW (request frequentielijnen for locations along coast)
[ ] prevent the need to supply dict with 'Hydra-NL' distribution, this is typo-risky
[ ] HYDRA-RING also relevant for deceedance?
[ ] simplify rule_type and rule_value parameters, but keep in mind other applications
[ ] threshold for river discharge was disabled in calc_overschrijding(), this is more generic and suitable for coastal stations, but it has negative impact for benedenrivierengebied.
[ ] add extra tests/assertions (and increase code coverage)
[ ] many functions are not used, sometimes because there are multiple alternatives (hkv and non-hkv). Choose which functions to use and remove the rest
[ ] fix "RuntimeWarning: invalid value encountered in scalar power return -p_val_gt_threshold * (alpha * x**(alpha - 1)) * (sigma**(-alpha)) * np.exp(-((x/sigma)**alpha) + ((threshold/sigma)**alpha))" from test_calc_overschrijding
[ ] get_threshold_rowidx base treshold on frequency or value?
Todo:
calc_overschrijding(), this is more generic and suitable for coastal stations, but it has negative impact for benedenrivierengebied."RuntimeWarning: invalid value encountered in scalar power return -p_val_gt_threshold * (alpha * x**(alpha - 1)) * (sigma**(-alpha)) * np.exp(-((x/sigma)**alpha) + ((threshold/sigma)**alpha))"fromtest_calc_overschrijdingget_threshold_rowidxbase treshold on frequency or value?