[x] comp_av.attrs['fu_alltimes'] = True and comp_frommeasurements_avg_sncomp.attrs['fu_alltimes'] = True might be redundant. It might have a positive effect on the resulting tidal waves, then consider adding it in the analysis already so ana/pred settings are consistent. >> no effect whatsoever, so removed
[x] add min_coverage argument to calc_gemiddeldgetij, to pass on to calc_havengetallen
[x] maybe not use df_ext in reshape_signal, scale based on min/max derived from series directly. The df_ext was also derived from this same series right? >> this is the internal method and also used to crop the timeseries from hw to hw. Leave as is.
Todo:
comp_av.attrs['fu_alltimes'] = True
andcomp_frommeasurements_avg_sncomp.attrs['fu_alltimes'] = True
might be redundant. It might have a positive effect on the resulting tidal waves, then consider adding it in the analysis already so ana/pred settings are consistent. >> no effect whatsoever, so removedmin_coverage
argument tocalc_gemiddeldgetij
, to pass on tocalc_havengetallen
df_ext
inreshape_signal
, scale based on min/max derived from series directly. The df_ext was also derived from this same series right? >> this is the internal method and also used to crop the timeseries from hw to hw. Leave as is.