search

Deltares / GEOLib

GEOLib: Python wrappers around the input and output files of the Deltares D-Serie models
https://deltares.github.io/GEOLib/
MIT License
22 stars 17 forks source link

expose missing args in BishopBruteForceresult #163

Closed MatthiasHauthDeltares closed 9 months ago

MatthiasHauthDeltares commented 11 months ago

Parsing or executing a file which had BishopBruteForce as calculation method would raise an error because of the missing exposed attributes for the class BishopBruteForceResults

carloslubbers commented 11 months ago

These properties are part of the upcoming D-Stability 2024.01 release, so this is not something we can release just yet. We were planning on making a PR for that later as well, but if you want to you could maybe start that PR off with this change (and the missing properties for the other calculation types as well!)

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

breinbaas commented 10 months ago

seems like I've been working on that issue as well, my code is a little more complicated but if this works then it's fine, see https://github.com/Deltares/GEOLib/issues/170

breinbaas commented 10 months ago

If I use this option I get the following error when parsing a stix file;

Error: Project could not be opened. Error converting value {null} to type 'System.Double'. Path 'ResultThreshold', line 2, position 27.

I have solved this using ResultThreshold: Optional[float] = 0.0 although this does differ from the other options that are set to None

wfaustmann commented 9 months ago

Fixed in GEOLib v2.3.0 using a similar approach as proposed here