Deltares / GEOLib

GEOLib: Python wrappers around the input and output files of the Deltares D-Serie models
https://deltares.github.io/GEOLib/
MIT License
22 stars 17 forks source link

2024 DStability changes #170

Closed breinbaas closed 9 months ago

breinbaas commented 10 months ago

Creating a DStability model and then trying to calculate it using 2024.01 results in the following error;

Output file generated but parsing of ... 34-1_0.45-0.81_0.stix failed.

pydantic.error_wrappers.ValidationError: 2 validation errors for UpliftVanParticleSwarmResult
ResultThreshold
  extra fields not permitted (type=value_error.extra)
SlipPlaneResults
  extra fields not permitted (type=value_error.extra)

This is due to missing fields in the geolib code.

breinbaas commented 10 months ago

fixed for upliftvanparticleswarm -> needed to set

ResultThreshold: float = 0.0

instead of

ResultThreshold: Optional[float] = None

because the latter leads to models that cannot be opened in 2024.01

breinbaas commented 10 months ago

fixed bishop brute force / spencer genetic algorithm where fields were added as well

breinbaas commented 10 months ago

There seems to be a bugfix already; https://github.com/Deltares/GEOLib/pull/163

Not sure which code is better!

wfaustmann commented 9 months ago

Fixed in GEOLib v2.3.0