Open veenstrajelmer opened 1 year ago
TODOs for hydromt-delft3dfm:
Dataset
, with quantity
(e.g. "waterlevelbnd") as a variable.index
to locations
or location
- locations being the first support point on the pli line. The choice is because 1) consistent with 2D3D forcing types 2) avoid repeating forcing blocks 3) the kernel will interpolate along the linelocation_x
, location_y
, and location_name
TODOS in general:
Dataset
. Agree on any further discrepancies. hydrolib-core
. hydrolib-core
team how to best integrate with the current code. Dataset
if needed
Is your feature request related to a problem? Please describe. Several packages and users are converting hydrolib-core objects to (geo)pandas and other classes, related issues:
Describe the solution you'd like Put the converter functions from dfm_tools, dfm_tools and hydromt_delft3dfm into hydrolib core.
The idea is to set the necessary libraries as optional dependencies, so hydrolib-core can still be installed with the bare minimum: https://github.com/Deltares/HYDROLIB-core/issues/552
First rename in dfm_tools (JV):