search

Deltares / HYDROLIB-core

Core code around the I/O of the DHYDRO-suite
https://deltares.github.io/HYDROLIB-core/
MIT License
24 stars 4 forks source link

Investigate numpy 2.0.0 support #657

Open veenstrajelmer opened 3 weeks ago

veenstrajelmer commented 3 weeks ago

Is your feature request related to a problem? Please describe. Numpy 2.0.0 was released on 16 June 2024. HYDROLIB-core enforces numpy<2.0.0 via the pyproject.toml, so it will not be installed. However it is good to be future proof and test if everything still works when also allowing numpy 2.0.0 and above.

Describe the solution you'd like A quick investigation at least, preferably resulting in support for numpy>=2

Additional information Poetry is always blocking these types of tests. In fixing https://github.com/Deltares/HYDROLIB-core/issues/599 we saw that poetry thinks that all python versions must be able to install the same numpy version for some reason. It seems very likely that supporting numpy 2 is only neatly possible after dropping python 3.8 support.

evetion commented 2 weeks ago

Python 3.8 is end of life (EOL) in 3 months and 3 weeks (31 Oct 2024, 5 years old at that point), so dropping that seems a good thing.