Deltares / HYDROLIB

Python tools for modelling workflows using D-HYDRO Suite.
https://deltares.github.io/HYDROLIB/
GNU Lesser General Public License v3.0
23 stars 7 forks source link

HydroMT: have both 1D and 2D in mesh component #141

Closed hboisgon closed 1 month ago

hboisgon commented 1 year ago

So far, we use self.mesh for the 2D mesh and self.branches for 1D (GeoDataFrame) and self.dfmmodel.netfile.network._mesh1d. Ideally all mesh components should be contained into self.mesh and we should use xugrid / meshkernel functions for every mesh manipulations without having to use hydrolib-core classes in between.

This requires the following changes:

xldeltares commented 1 year ago

update: xugrid now supports mesh1d

veenstrajelmer commented 1 month ago

This issue will be closed as won't do since hydromt_delft3dfm moved to a separate repos.