Deltares / Ribasim-NL

Ribasim water resources modeling in the Netherlands
https://ribasim.nl/
MIT License
4 stars 0 forks source link

Fix HWS model `TabulatedRatingCurve` with new Ribasim checks #89

Open SouthEndMusic opened 3 months ago

SouthEndMusic commented 3 months ago

TabulatedRatingCurve has some new checks built in in the core (see here), which make the HWS model fail:

┌ Error: The `flow_rate` cannot decrease with increasing `level`.
│   node_id = TabulatedRatingCurve #37
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:431
┌ Error: The `flow_rate` cannot decrease with increasing `level`.
│   node_id = TabulatedRatingCurve #49
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:431
┌ Error: The `flow_rate` must start at 0.
│   node_id = TabulatedRatingCurve #88
│   flow_rate = 685.6
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:421
┌ Error: The `flow_rate` must start at 0.
│   node_id = TabulatedRatingCurve #148
│   flow_rate = 125.4
└ @ Ribasim c:\Users\konin_bt\Ribasim_development\Ribasim\core\src\validation.jl:421
DanielTollenaar commented 3 months ago

On one hand; logical choice not to accept it in the solver. On the other; now we need to put complex discharge/supply-controls in multiple links with controllers. Let's discuss 28/8 how (to keep it as simple as possible).