Deltares / Ribasim

Water resources modeling
https://deltares.github.io/Ribasim/
MIT License
36 stars 5 forks source link

Incorporate SmoothInterpolation #1543

Closed SouthEndMusic closed 1 week ago

SouthEndMusic commented 2 weeks ago

Fixes https://github.com/Deltares/Ribasim/issues/1482 Fixes https://github.com/Deltares/Ribasim/issues/566

SouthEndMusic commented 2 weeks ago

I smelled something fishy when I found out that on this branch the AGV model takes 3-4x longer than on main. No tests are failing, and noting remarkable shows up in the profile. So I investigated a bit, and I found that the profile for certain basins behaves weird in the old code:

weird_plot

I haven't figured out what triggers this yet, but apparently it doesn't happen in our test models, at least not where tests depend on it. I'm pretty sure the new code (in SmoothInterpolation) is more correct and robust because it is tested more elaborately.