Closed visr closed 1 week ago
Looks good to me. In terms of which struct to make use of this macro and to have default parameter, I trust you. For the unit tests, I don't see any unit tests that can make use of this being left out. Approve (I also got your failing test on TC passed)
By putting the kwdef macro in front of our struct definitions we can create them with keywords and set defaults if applicable. This helps with readability and makes it less likely to pass the wrong argument due to a wrong order. E.g. compare this test code before and after: