Deltares / Ribasim

Water resources modeling
https://deltares.github.io/Ribasim/
MIT License
36 stars 5 forks source link

NumPy 2 support #1573

Open visr opened 1 week ago

visr commented 1 week ago

In https://github.com/conda-forge/ribasim-feedstock/pull/17 I had to add numpy <2.0. We should add that as well in the pyproject.toml, or look into supporting NumPy 2 directly.

We should use the ruff rule as mentioned in https://numpy.org/doc/stable/numpy_2_0_migration_guide.html.

Error in the feedstock was seemingly from pandera:

  File "/home/conda/feedstock_root/build_artifacts/ribasim_1718990264152/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.12/site-packages/pandera/strategies/pandas_strategies.py", line 42, in <module>
    from pandera.engines import numpy_engine, pandas_engine
  File "/home/conda/feedstock_root/build_artifacts/ribasim_1718990264152/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.12/site-packages/pandera/engines/pandas_engine.py", line 757, in <module>
    np.string_,
    ^^^^^^^^^^
  File "/home/conda/feedstock_root/build_artifacts/ribasim_1718990264152/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.12/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: `np.string_` was removed in the NumPy 2.0 release. Use `np.bytes_` instead.. Did you mean: 'strings'?