Fix QGIS crash on plugin initialization

Deltares / Ribasim

Water resources modeling

https://ribasim.org/

MIT License

39 stars 5 forks source link

Fix QGIS crash on plugin initialization #1580

Closed visr closed 3 months ago

visr commented 3 months ago

Fixes #993, by creating the column count first before setting their properties, and changing the index to 0 (0-based, first), since we now have only one column.

Based on the suggestion by @Huite in https://github.com/Deltares/Ribasim/issues/993#issuecomment-2187242512. By repeatedly running pixi run test-ribasim-qgis-ui I am quite confident this fixes the issue. If I change the 0 back to 1 I got a crash again within a few tries.

Huite commented 3 months ago

It makes sense that this fixes it (although still weird that doesn't just raises an exception).

I've approved, although take a look at my review comments -- since you're looking at this anyway.

visr commented 3 months ago

Thanks, addressed comments in 7cd92b32776c2fae8d44cbc95f7b67850b47f2b5.

Looks good now: