search

Deltares / Ribasim

Water resources modeling
https://ribasim.org/
MIT License
39 stars 5 forks source link

Remove TimerOutputs #1749

Closed visr closed 1 month ago

visr commented 1 month ago

Fixes #1741.

Note that this is still an indirect dependency.

(root) pkg> why TimerOutputs
  Ribasim → DiffEqCallbacks → NonlinearSolve → TimerOutputs
  Ribasim → OrdinaryDiffEq → NonlinearSolve → TimerOutputs
evetion commented 1 month ago

I'm sorta sorry to see this go, but if we don't use it, why not.

visr commented 1 month ago

Yeah same, we can always bring it back. Though I feel it is hard to get good enough timing information this way. Some of the stuff we care most about is happening in dependencies. Profiling is much more informative. And we have also added results/solver_stats.arrow since.