search

Deltares / Ribasim

Water resources modeling
https://ribasim.org/
MIT License
42 stars 5 forks source link

Re-enable `BackTracking` #1761

Closed SouthEndMusic closed 2 months ago

SouthEndMusic commented 2 months ago

BackTracking as relaxation is now enabled again, with a thin wrapper to reject it when the residual gets worse. Upstream issue:

https://github.com/SciML/OrdinaryDiffEq.jl/issues/2442

visr commented 2 months ago

Since the sensible gradients don't fix the Crystal model with BackTracking, I guess we should not enable that yet?

How do these gradients compare with Shampine's advice in https://github.com/Deltares/Ribasim/issues/1705#issuecomment-2283312301, should we bring that back as well in this PR?

SouthEndMusic commented 2 months ago

I added Shampine's advice, but it doesn't seem to change anything