Validate data table node_ids against Node

[DanielTollenaar]

Ribasim-main (commit 5d94880) seems to give an invalid Outlet crest_level validation using the wrong upstream basin

Reproduction

1. Download https://deltares.thegood.cloud/f/118499
2. Run in latest (commit 5d94880) version of RIBASIM will give you this validation-error:

Obervation

• Inspecting the model network you see node_id 627 is indeed an Outlet and upstream Basin node_id 1140

• Inspecting the Basin / Profile table leads to the following observation:

  • Basin node_id 1140 has a min level of -1.69 which is lower than the crest_level of Outlet node_id 627 (correctly given as -1.59)
  • Basin node_id 1139 has a min level of 25.47 which is the same as the basin_bottom_level mentioned in the Error (but not the correct upstream basin node_id

• Comparing Outlet 996 and basin 1228 (second Error) gives the same observation

Conclusion

• Validator compares the correct Outlet min_crest_level with the wrong Basin / Profile
• Basin node_ids may have been shifted by 1

[visr]

In create_storage_tables we read the sorted Basin / profile and then assume the node IDs match the sorted Node table. In this model there are 856 Basin nodes according to Node, and 864 different node IDs in Basin / profile.

For example, node ID 1058 is in Basin / profile but not in Node. Can these be filtered out?

This should be validated better in the core, so we should keep this issue open for that.