Deltares / Ribasim

Water resources modeling
https://ribasim.org/
MIT License
42 stars 5 forks source link

Remove `OrdinaryDiffEq` internals #1784

Open SouthEndMusic opened 2 months ago

SouthEndMusic commented 2 months ago

Fixes https://github.com/Deltares/Ribasim/issues/1778.

See also https://github.com/SciML/OrdinaryDiffEq.jl/pull/2443.

SouthEndMusic commented 3 weeks ago

Things I changed:

It must be noted that even though NonlinearSolveAlg with finite difference and BackTracking from LineSearch.jl works, I observed a huge drop in performance for the HWS model. Interestingly, looking at the profile reveals that this performance drop is at least in part due to runtime dispatch and allocations in OrdinaryDiffEqNonlinearSolve, so that subpackage is clearly not mature enough to be used.