Support time dependent parameters for pump and outlet types

visr commented 1 year ago

Currently only Basin and TabulatedRatingCurve support it.

What is needed:

[ ] create the schemas in validation.jl
[ ] add the schemas to the usage docs
[ ] run gen_schema.jl
[ ] add the schemas to python and QGIS
[ ] write an update_x callback in bmi.jl and use it
[ ] update the table list in https://deltares.github.io/Ribasim/core/usage.html#node

If #178 would be merged first these steps might change a little.

For Basin the time-dependent table is called Basin / forcing, but I'd propose " / time" for all these tables. The TabulatedRatingCurve is unique in that a table has to be updated rather than scalars. For the other node types it will probably look more similar to the basin_update. I guess perhaps it is possible to automate parts of this, but that could also be done after implementing it manually first. Right now it's a limitation that only some things can get updated.

EDIT 2024-01: @Fati-Mon needs Pump / time and Outlet / time.

evetion commented 1 year ago

I guess perhaps it is possible to automate parts of this, but that could also be done after implementing it manually first.

Refinement: let's check the duplication and automate/generalize after the first manual implementation(s).

SouthEndMusic commented 1 year ago

Sub issues:

https://github.com/Deltares/Ribasim/issues/397 https://github.com/Deltares/Ribasim/issues/439

harm-nomden-sweco commented 8 months ago

What about time dependent control levels for the DiscreteControl?

visr commented 8 months ago

That would also be nice to have, but implementation wise is quite different from this issue. Right now we only support control_state in the static tables. See also #298.

Deltares / Ribasim

Support time dependent parameters for pump and outlet types #208