Take node activity into account in allocation

Deltares / Ribasim

Water resources modeling

https://ribasim.org/

MIT License

42 stars 5 forks source link

Take node activity into account in allocation #728

Open SouthEndMusic opened 1 year ago

SouthEndMusic commented 1 year ago

Allocation should not send flow trough model nodes that are inactive (node.active = false). This also means either that these nodes have to be represented explicitly in the allocation graph, or that it has to be known which edge in the allocation graph this model node belongs to. When the edges connected to this node are known their capacities must be set to 0.0.

Suggested for discussion with RTC-Tools team members.

gijsber commented 1 year ago

I am a little in doubt how to deal with this. Hydrologic has the idea to using parallel nodes for the inlet of the Irene sluizen where Control rules determine how much nodes are active. in that case allocation should not neglect inactive nodes as they may provide the additioanl capacity.

Maybe #753 is also applicable for this situation. But in that case it would be nice if we could put a cap (max_flow_rate) on such Tabulated Rating Curve such that allocation has an idea what could be expected from such type of inlet

SouthEndMusic commented 9 months ago

After discussion with the RTC tools team we concluded the following:

[ ] It's fine for performance to have capacity constraints on all edges, not only the ones that have finite capacity;
[ ] Inactive nodes can be taken into account by setting the capacity of the corresponding edges to 0;
[ ] When DiscreteControl changes the activity of a node, allocation optimization has to be done again.

visr commented 5 months ago

Related to this, the UserDemand schema supports active, but LevelDemand and FlowDemand do not. It probably makes most sense to add this after or when this issue is fixed.