remove `Parameter_Wat_Omschrijving` in `_combine_waarnemingenlijst` - Githubissues

Deltares / ddlpy

API to Dutch Rijkswaterstaat archive (DDL, waterinfo.rws.nl) of monitoring water data

https://deltares.github.io/ddlpy/

GNU General Public License v3.0

19 stars 6 forks source link

remove `Parameter_Wat_Omschrijving` in `_combine_waarnemingenlijst` #103

Closed veenstrajelmer closed 3 months ago

veenstrajelmer commented 3 months ago

ddlpy version: 0.5.0
Python version: 3.11
Operating System: Windows

Description

Several columns of the locations dataframe are copied to the measurements dataframe in this part of the code: https://github.com/Deltares/ddlpy/blob/054566ca633150cc7f627851f56637ae7b2ad15b/ddlpy/ddlpy.py#L256-L263

The Parameter_Wat_Omschrijving column is already present in the measurements dataframe so does not have to be copied.

Also add testcase for precense of these columns in both locations and measurements dataframes