Empty dataframe line 171 in ddlpy.py

Deltares / ddlpy

API to Dutch Rijkswaterstaat archive (DDL, waterinfo.rws.nl) of monitoring water data

https://deltares.github.io/ddlpy/

GNU General Public License v3.0

20 stars 6 forks source link

Empty dataframe line 171 in ddlpy.py #7

Closed HesselVoortman closed 2 years ago

HesselVoortman commented 3 years ago

Data Distributie Laag. Service from Rijkswaterstaat for distributing water quantity data. version:
Python version: 3.8
Operating System: Windows

Description

Downloading data station Lobith. Dataframe "measurements" empty after removal of duplicates.

What I Did

Line 171 in ddlpy.py reads: measurements = measurements.drop_duplicates(inplace = True)

Modified to: measurements.drop_duplicates(inplace = True)

which yields the correct result and avoids the error.

SiggyF commented 2 years ago

Thanks for your contribution Hessel. It is now implemented as measurements = measurements.drop_duplicates() which is the same as measurements.drop_duplicates(inplace = True).

veenstrajelmer commented 6 months ago

Another release of ddlpy was created today and all docs and examples were updated. Please open a new issue if you encounter any bugs.