Deltares / dfm_tools

A Python package for pre- and postprocessing D-FlowFM model input and output files
https://deltares.github.io/dfm_tools/
GNU General Public License v3.0
68 stars 11 forks source link

JSONDecodeerror for UHSLC with `fiona>=1.10.0` #1000

Closed veenstrajelmer closed 1 week ago

veenstrajelmer commented 2 weeks ago

Wait until one of these issues is fixed and then update dfm_tools code and/or minimal versions to resolve the failing testcases:

FAILED tests/test_modelbuilder.py::test_cmems_nc_to_ini_midnight_centered - ModuleNotFoundError: No module named 'tests'
FAILED tests/test_observations.py::test_ssh_catalog_subset_expected_fields[uhslc-fast] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
FAILED tests/test_observations.py::test_ssh_catalog_subset_expected_fields[uhslc-rqds] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
FAILED tests/test_observations.py::test_ssh_catalog_subset[uhslc-fast] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
FAILED tests/test_observations.py::test_ssh_catalog_subset[uhslc-rqds] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
FAILED tests/test_observations.py::test_ssh_retrieve_data[uhslc-fast] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
FAILED tests/test_observations.py::test_ssh_retrieve_data[uhslc-rqds] - json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)
veenstrajelmer commented 1 week ago

The geojson was updated as suggested in https://github.com/Toblerity/Fiona/issues/1451#issuecomment-2366896427, so the tests pass again.