Deltares / hatyan

Harmonic tidal analysis and prediction
https://deltares.github.io/hatyan/
GNU General Public License v3.0
13 stars 2 forks source link

simplify public functions by deprecating some arguments #299

Closed veenstrajelmer closed 4 months ago

veenstrajelmer commented 4 months ago

Todo:

get_status was removed from hatyan.read_dia() since it is not used. DDL/ddlpy is a good alternative to get full metadata with measurements.

if get_status: #TODO: this can be more generic (eg add additional metadata) or more neat. Also in get_diablocks()
    block_status_list = diablocks_pd.loc[block_id,'STA'].split('!')
    for block_status_one in block_status_list:
        status_tstart = dt.datetime.strptime(block_status_one[4:17],'%Y%m%d;%H%M')
        status_tstop = dt.datetime.strptime(block_status_one[18:31],'%Y%m%d;%H%M')
        status_val = block_status_one[-1]
        data_pd_oneblock.loc[status_tstart:status_tstop,'Status'] = status_val