The code below raises "ValueError: metadata for two datasets is not equal, cannot be merged:" because of varying timestep_min. This should be ignored when merging timeseries.
This also includes setting the metadata from the first block as the metadata of the merged timeseries, which will then not contain a timestep_min. Also the tstart/tstop are derived assuming the blocks are ordered in time which is not always the case.
Todo:
[x] add testcase that fails with current setup
[x] drop tstart/tstop attrs from timeseries dataframes, only keep for component dataframes
[x] drop tzone attrs from timeseries dataframes, only keep for component dataframes
[x] drop timestep_min attrs from timeseries dataframes, can probably be dropped throughout the code
[x] remove timestep_min from metadata before comparing them (but keep in mind that it is added as metadata to the merged dataset also) >> not added to metadata anymore
The code below raises
"ValueError: metadata for two datasets is not equal, cannot be merged:"
because of varyingtimestep_min
. This should be ignored when merging timeseries.The code for metadata comparison is this part: https://github.com/Deltares/hatyan/blob/8a004bc4126d8c47a3aafb2c34688dbe78211ccd/hatyan/timeseries.py#L1584-L1590
This also includes setting the metadata from the first block as the metadata of the merged timeseries, which will then not contain a timestep_min. Also the tstart/tstop are derived assuming the blocks are ordered in time which is not always the case.
Todo: