I think I've updated everything discussed in #862 this pr mostly updates time_tuple -> time_range and fn -> path or fn -> data as appropriate. I think with that we have fixed all the non data convention issues that we've discussed but feel freet o point out any I've missed.
General Checklist
[x] Updated tests or added new tests
[x] Branch is up to date with main
[x] Tests & pre-commit hooks pass
[ ] Updated documentation
[x] Updated changelog.rst
Data/Catalog checklist
[ ] data/catalogs/predefined_catalogs.yml has not been modified.
[ ] None of the old data_catalog.yml files have been chagned
[ ] data/chagnelog.rst has been updated
[ ] new file uses LF line endings (done automatically if you used update_versions.py)
[ ] New file has been tested locally
[ ] Tests have been added using the new file in the test suite
Additional Notes (optional)
Add any additional notes or information that may be helpful.
Issue addressed
Fixes #821 Fixes #834
Explanation
I think I've updated everything discussed in #862 this pr mostly updates
time_tuple -> time_rangeandfn -> pathorfn -> dataas appropriate. I think with that we have fixed all the non data convention issues that we've discussed but feel freet o point out any I've missed.General Checklist
mainData/Catalog checklist
data/catalogs/predefined_catalogs.ymlhas not been modified.data_catalog.ymlfiles have been chagneddata/chagnelog.rsthas been updatedLFline endings (done automatically if you usedupdate_versions.py)Additional Notes (optional)
Add any additional notes or information that may be helpful.