Update export catalog - Githubissues

Deltares / hydromt

HydroMT: Automated and reproducible model building and analysis

https://deltares.github.io/hydromt/

MIT License

75 stars 30 forks source link

Update export catalog #1052

Closed Jaapel closed 2 months ago

Jaapel commented 2 months ago

Issue addressed

Fixes #886

Explanation

I moved the DataCatalog.export_data to the new class structure. Next to using the correct classes, I had to:

Fixed a bug in the migrate_datacatalog script to make sure that the tileindex option ended up in the resolver
Changed the exported uri to something sensible if the format changes during export. This behaviour is included in the driver.
Changed some catalog references to match the 0.9 and 1.0 references. I wonder how that ever worked in v0.

General Checklist

[x] Updated tests or added new tests
[x] Branch is up to date with v1
[x] Tests & pre-commit hooks pass
[ ] Updated documentation
[ ] Updated changelog.rst

Data/Catalog checklist

[ ] data/catalogs/predefined_catalogs.yml has not been modified.
[ ] None of the old data_catalog.yml files have been changed
[ ] data/chagnelog.rst has been updated
[ ] new file uses LF line endings (done automatically if you used update_versions.py)
[ ] New file has been tested locally
[ ] Tests have been added using the new file in the test suite

savente93 commented 2 months ago

I'll give it an early review tomorrow