Deltares / hydromt

HydroMT: Automated and reproducible model building and analysis
https://deltares.github.io/hydromt/
MIT License
69 stars 29 forks source link

Test suite should not access internet directly #396

Open savente93 opened 1 year ago

savente93 commented 1 year ago

HydroMT version checks

Reproducible Example

pip install pytest-socket pytest --disable-socket

Current behaviour

Some of the tests directly access the internet. This is bad practice for performance, security and reproducability.

Desired behaviour

The access to the relevant services should get mocked and the processing of the relevant data should be tested separately.

Additional context

No response

DirkEilander commented 1 year ago

We access the internet to get data catalogs and artifact data.

@savente93 Do you have suggestions how to go ahead on these points without internet access? And how big is this issue in your opinion?

savente93 commented 1 year ago

I've got some ideas. It is not a big issue though, more of a nice to have. I will pick this up when I have the time at some point but we do not need to prioritize it at the moment