The only thing left to fix that is in scope for this ticket was an __eq__ implementation for DataSource. Since the driver includes things like the fs for which it's not really clear what equality means, and I also think it makes sense that we'll consider data sources the same regardless of which driver we read them through, I think it makes sense to exclude it from that.
General Checklist
[x] Updated tests or added new tests
[x] Branch is up to date with v1
[ ] Tests & pre-commit hooks pass
[ ] Updated documentation
[ ] Updated changelog.rst
Additional Notes (optional)
Add any additional notes or information that may be helpful.
savente93
commented
1 month ago
Issue addressed
Fixes #937
Explanation
The only thing left to fix that is in scope for this ticket was an
__eq__implementation forDataSource. Since thedriverincludes things like thefsfor which it's not really clear what equality means, and I also think it makes sense that we'll consider data sources the same regardless of which driver we read them through, I think it makes sense to exclude it from that.General Checklist
v1Additional Notes (optional)
Add any additional notes or information that may be helpful.