937/finish data catalog tests

[Jaapel]

Issue addressed

Fixes #937

Explanation

Fixed final tests and added some extra robustness to the convention resolve to achieve it.

General Checklist

• [x] Updated tests or added new tests
• [x] Branch is up to date with v1
• [x] Tests & pre-commit hooks pass
• [ ] Updated documentation
• [ ] Updated changelog.rst

[Jaapel]

@savente93 let's just enable this warning collection on all envs and remove the single workflow for erroring out on warnings?

[savente93]

I'm happy to do that, if other people don't mind. will it help for this one?

[Jaapel]

Yes it should now error out on unexpected warnings in the tests workflows