938/reenable test forcing - Githubissues

Deltares / hydromt

HydroMT: Automated and reproducible model building and analysis

https://deltares.github.io/hydromt/

MIT License

65 stars 28 forks source link

938/reenable test forcing #996

Closed Tjalling-dejong closed 2 weeks ago

Tjalling-dejong commented 2 weeks ago

Issue addressed

Fixes #938

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

General Checklist

[ ] Updated tests or added new tests
[ ] Branch is up to date with main
[ ] Tests & pre-commit hooks pass
[ ] Updated documentation
[ ] Updated changelog.rst

Data/Catalog checklist

[ ] data/catalogs/predefined_catalogs.yml has not been modified.
[ ] None of the old data_catalog.yml files have been chagned
[ ] data/chagnelog.rst has been updated
[ ] new file uses LF line endings (done automatically if you used update_versions.py)
[ ] New file has been tested locally
[ ] Tests have been added using the new file in the test suite

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Tjalling-dejong commented 2 weeks ago

Can't on anything underlying/semantic but the code looks good to me so I'm fine with it.

Can't on anything underlying/semantic but the code looks good to me so I'm fine with it.

The tests are mostly superficial. I'm also not familiar with the mathematics of the formulas used. I test if the functions run without error and they should fail if the results change due to unexpected changes in updates for example.