Bugfix setup channels and 2d1d links

shartgring commented 3 months ago

Issue addressed

Fixes #131 and #132

Explanation

Some typos and incorrect variable types resulted in errors being raised. This PR solves this by removing the typos and adapting some of the code copied from hydrolib to be able to work with correct variable types. This is not an improvement of the functionality, but merely bigfixing

Checklist

[X] Updated tests or added new tests
[X] Branch is up to date with main
[X] Tests & pre-commit hooks pass
[x] Updated documentation if needed <-- default for spacing has been set to np.inf, include this in documentation?
[x] Updated changelog.rst if needed <-- should I add specifics on the bugfixes, or can we call it 'bufixing' in general? Or maybe refer to the methods where the bugs have been fixed?

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

shartgring commented 2 months ago

@hboisgon I addressed your points! It will not affect the examples as setup_channels is not included in the examples (thus they are not affected by the changes). I will make an issue that it would be good to include it, as such an example can also be used for tests

Deltares / hydromt_delft3dfm