Global snapping settings may cause problems - Githubissues

Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT

https://deltares.github.io/hydromt_delft3dfm/

GNU General Public License v3.0

7 stars 1 forks source link

Global snapping settings may cause problems #143

Open shartgring opened 1 week ago

shartgring commented 1 week ago

Version checks

[X] I have checked that this issue has not already been reported.
[X] I have checked that this bug exists on the latest version.

Reproducible Example

The current default values for snapping are strict (25 meters, see also https://github.com/Deltares/hydromt_delft3dfm/blob/73b79bf71ae87ebced28a4ab207e9ef2e99a2d4c/hydromt_delft3dfm/dflowfm.py#L122). And new branches are snapped to existing branches by default. Both can cause problems when working with small-scale models.

Current behaviour

Snapping of branches is troublesome due to a strict global value being applied

Desired behaviour

Relax the global value and provide a maximum snapping distance option per method

Additional context

No response